Skip to content

Part 3️⃣ of removing CfWorkerInit["bindings"]#12487

Merged
petebacondarwin merged 3 commits intomainfrom
penalosa/granular-refactor-3
Feb 9, 2026
Merged

Part 3️⃣ of removing CfWorkerInit["bindings"]#12487
petebacondarwin merged 3 commits intomainfrom
penalosa/granular-refactor-3

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Feb 9, 2026

Part 3 of landing #12151 in stages. This part:

  • Modifies printBindings to use flat bindings format internally
  • Adds getBindingTypeFriendlyName to workers-utils
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: covered by existing tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor
Open with Devin

@penalosa penalosa requested a review from a team as a code owner February 9, 2026 13:48
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 9, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2665d8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa force-pushed the penalosa/granular-refactor-3 branch from 94dc9e4 to 1a8b638 Compare February 9, 2026 13:51
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Feb 9, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 9, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12487

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12487

miniflare

npm i https://pkg.pr.new/miniflare@12487

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12487

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12487

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12487

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12487

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12487

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12487

wrangler

npm i https://pkg.pr.new/wrangler@12487

commit: 2665d8d

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Open in Devin Review

Base automatically changed from penalosa/granular-refactor-2 to main February 9, 2026 17:29
penalosa and others added 2 commits February 9, 2026 17:34
@penalosa
Refactor print-bindings to use flat bindings format
87940cb 
- Convert printBindings to use StartDevWorkerInput["bindings"] format internally
- Add printFlatBindings for the new flat Record<string, Binding> format
- Extract bindings by type using extractBindingsOfType utility
- Preserve var insertion order when extracting plain_text, json, secret_text
- Strip unsafe_ prefix when displaying unsafe binding types
- Add getBindingTypeFriendlyName to workers-utils for consistent naming
@penalosa @devin-ai-integration
Update packages/wrangler/src/utils/print-bindings.ts
5b8c78c 
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@penalosa penalosa force-pushed the penalosa/granular-refactor-3 branch from 1a8b638 to 5b8c78c Compare February 9, 2026 17:34
vicb
vicb reviewed Feb 9, 2026
View reviewed changes
Comment thread packages/workers-utils/src/config/validation.ts
vicb
vicb reviewed Feb 9, 2026
View reviewed changes
Comment thread packages/wrangler/src/utils/print-bindings.ts
vicb
vicb reviewed Feb 9, 2026
View reviewed changes
Comment thread packages/wrangler/src/utils/print-bindings.ts Outdated
vicb
vicb reviewed Feb 9, 2026
View reviewed changes
Comment thread packages/wrangler/src/utils/print-bindings.ts
vicb
vicb reviewed Feb 9, 2026
View reviewed changes
Comment thread packages/wrangler/src/utils/print-bindings.ts Outdated
vicb
vicb approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nits/thoughts

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 9, 2026
@penalosa penalosa mentioned this pull request Feb 9, 2026
Open
@petebacondarwin petebacondarwin merged commit 9dd97df into main Feb 9, 2026
47 of 48 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 9, 2026
@petebacondarwin petebacondarwin deleted the penalosa/granular-refactor-3 branch February 9, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

no-changeset-required

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@penalosa @vicb @petebacondarwin @workers-devprod