Skip to content

Warn when the assets field is provided for auxiliary Workers#12834

Merged
jamesopstad merged 6 commits intomainfrom
james/assets-warnings
Mar 11, 2026
Merged

Warn when the assets field is provided for auxiliary Workers#12834
jamesopstad merged 6 commits intomainfrom
james/assets-warnings

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad commented Mar 10, 2026

Fixes #12801

Warn when the assets field is provided for auxiliary Workers

Auxiliary Workers do not support static assets. Previously, the assets field was silently ignored but we now warn if it is used.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: TODO

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@jamesopstad jamesopstad requested a review from a team as a code owner March 10, 2026 16:19
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2026

🦋 Changeset detected

Latest commit: 06c1241

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 10, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

✅ All changesets look good

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 10, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12834

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12834

miniflare

npm i https://pkg.pr.new/miniflare@12834

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12834

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12834

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12834

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12834

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12834

wrangler

npm i https://pkg.pr.new/wrangler@12834

commit: 690cfd7

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a very minor nit 🙂

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Mar 10, 2026
@jamesopstad jamesopstad merged commit 64edac7 into main Mar 11, 2026
35 checks passed
@jamesopstad jamesopstad deleted the james/assets-warnings branch March 11, 2026 12:07
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[vite-plugin]: Static asset bindings are undefined.

3 participants