[vitest-pool-workers] add disableRetryDelays() to skip retry backoff delays in workflow tests#12858
Merged
pombosilva merged 2 commits intocloudflare:mainfrom Mar 30, 2026
Conversation
🦋 Changeset detectedLatest commit: 8228ce6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
1 task
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
d3e4566 to
745c840
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
5189f12 to
3fed9d5
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
3fed9d5 to
923f861
Compare
923f861 to
ecf14c4
Compare
pombosilva
reviewed
Mar 27, 2026
Contributor
pombosilva
left a comment
There was a problem hiding this comment.
Looks great! Left a few comments
Can you also add the usage of this new handler to fixtures/vitest-pool-workers-examples/workflows/?
8dd2fac to
bdab160
Compare
…f delays in workflow tests
bdab160 to
a02fbaf
Compare
pombosilva
approved these changes
Mar 27, 2026
penalosa
approved these changes
Mar 27, 2026
Merged
NuroDev
pushed a commit
that referenced
this pull request
Mar 30, 2026
…f delays in workflow tests (#12858)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when testing a workflow step that has retry configuration, the backoff between retries will actually take effect even when the step results are full mocked, and burn real wall-time for no reason. this behavior still persists even when
disableSleeps()is called on the workflow.this changes adds a new method
disableRetryDelays()toWorkflowInstanceModifier, similar todisableSleeps(), which will cause the retry to occur immediately instead of after the configured backoff time. this can also be done to only specific steps as well.A picture of a cute animal (not mandatory, but encouraged)