Use Vite 8 for building the plugin and as the default for running tests#12936
Merged
jamesopstad merged 7 commits intomainfrom Mar 17, 2026
Merged
Use Vite 8 for building the plugin and as the default for running tests#12936jamesopstad merged 7 commits intomainfrom
jamesopstad merged 7 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 72b1133 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
jamesopstad
force-pushed
the
james/vite-8-default
branch
from
20d4c88 to
ecb782b
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM except that this failure in CI (around Vitest pool workers) looks legit:
jamesopstad
force-pushed
the
james/vite-8-default
branch
from
bc5db1d to
72b1133
Compare
Contributor
Author
Thanks. Fixed the failing test in 72b1133 and added a comment explaining the behaviour change. |
petebacondarwin
approved these changes
Mar 17, 2026
Merged
NuroDev
pushed a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Vite 8 for building the plugin and as the default for running tests.
The plugin now builds against Vite 8 and ships two bundled copies of
vite/module-runner: one from Vite 8 and one from Vite 7.1.12 (the last version before a breaking change to the module runner in Vite 7.2.0). At dev server startup, the correct implementation is selected based on the user's installed Vite version. This is Vite 8's module runner for users on Vite >= 7.2.0, and the legacy module runner for users on older versions.A picture of a cute animal (not mandatory, but encouraged)