Fix "Cannot perform I/O on behalf of a different request" errors for deferred dynamic imports#12953
Merged
jamesopstad merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 3a001b3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
706167c to
a7dedab
Compare
a7dedab to
3a001b3
Compare
Contributor
|
✅ All changesets look good |
jamesopstad
commented
Mar 26, 2026
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
penalosa
approved these changes
Mar 26, 2026
Contributor
|
I'm not super familiar with the internals of Vite's module runner, so this should probably also get a review from someone else more familiar with Vite. However, this is the same fix as Vitest needs, and that bit seems accurate to what I'd expect, so approving from that perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12731.
Fix
Cannot perform I/O on behalf of a different requesterrors for deferred dynamic importsConcurrent requests that loaded the same dynamic import were previously sharing the same promise to resolve it in a Worker context. We now ensure that all imports execute within a Durable Object's IoContext before the result is returned to the Worker.
This PR also revises and improves the module runner implementation more generally. We now only use public Vite APIs.
A picture of a cute animal (not mandatory, but encouraged)