[workflows-shared] fix waitForEvent delivering events to stale waiters after timeout#12985
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e6550cd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pombosilva
force-pushed
the
osilva/fix-workflows-waitForEvent
branch
from
9291595 to
6e25146
Compare
Contributor
|
✅ All changesets look good |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
pombosilva
force-pushed
the
osilva/fix-workflows-waitForEvent
branch
from
6e25146 to
53b24bd
Compare
pombosilva
force-pushed
the
osilva/fix-workflows-waitForEvent
branch
from
53b24bd to
e6550cd
Compare
penalosa
approved these changes
Mar 20, 2026
pombosilva
changed the title
avenceslau
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11740
When a
step.waitForEvent()times out, its resolve callback was not being removed from the Engine's waiters map. This meant the next waitForEvent call for the same event type would have its event consumed by the stale dead callback, causing that next live waiter to never resolve.A picture of a cute animal (not mandatory, but encouraged)