[miniflare] Fix mixed kvNamespaces and d1Databases records#12986
Merged
Conversation
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
penalosa
approved these changes
Mar 20, 2026
57a29b2 to
876f943
Compare
🦋 Changeset detectedLatest commit: 876f943 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
5 tasks
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the same schema validation bug as was fixed for
r2Buckets—kvNamespacesandd1Databasesbindings could not mix plain string values and object values in the same record.Previously, passing a config like:
would throw a Zod validation error because the schema used two separate
z.record(...)union branches — one accepting only strings, one accepting only objects. Zod would fail both branches when the values were mixed.The fix collapses the two
z.record(...)branches into a singlez.record(z.union([z.string(), z.object({...})])), matching the pattern already applied tor2Buckets. ThenamespaceEntries()helper inplugins/sharedalready handled mixed values correctly at runtime — only the schema validation was too restrictive.A picture of a cute animal (not mandatory, but encouraged)