Skip to content

Update some missing tests and fixtures with Vitest 4#12999

Merged
petebacondarwin merged 7 commits into
cloudflare:mainfrom
hiendv:vitest-4-missing-tests
Mar 23, 2026
Merged

Update some missing tests and fixtures with Vitest 4#12999
petebacondarwin merged 7 commits into
cloudflare:mainfrom
hiendv:vitest-4-missing-tests

Conversation

@hiendv
Copy link
Copy Markdown
Contributor

@hiendv hiendv commented Mar 21, 2026

Re #12947.

Migrate more outdated tests and fixtures to Vitest 4 and vpw 0.13.x



Open with Devin

@hiendv hiendv requested a review from a team as a code owner March 21, 2026 10:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 21, 2026

🦋 Changeset detected

Latest commit: 7c9e003

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 21, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 21, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12999

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12999

miniflare

npm i https://pkg.pr.new/miniflare@12999

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12999

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12999

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12999

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12999

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12999

wrangler

npm i https://pkg.pr.new/wrangler@12999

commit: 7c9e003

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the PR slightly to simplify the number of changes.

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Mar 22, 2026
@hiendv
Copy link
Copy Markdown
Contributor Author

hiendv commented Mar 22, 2026

@petebacondarwin Thanks a lot, I forgot that 😆

@hiendv
Copy link
Copy Markdown
Contributor Author

hiendv commented Mar 22, 2026

Btw, I don't know why this CI fails. It runs fine locally.
image

@petebacondarwin
Copy link
Copy Markdown
Contributor

I think it is because containers-shared checks need the workers-utils package to be built first

@petebacondarwin
Copy link
Copy Markdown
Contributor

Some other PR probably broke that but we have benefitted from cached build results, perhaps

@petebacondarwin petebacondarwin force-pushed the vitest-4-missing-tests branch from 0b11dfd to a66ec36 Compare March 22, 2026 17:50
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 22, 2026 17:50
@petebacondarwin petebacondarwin force-pushed the vitest-4-missing-tests branch from a66ec36 to 279ef5c Compare March 22, 2026 22:04
@petebacondarwin petebacondarwin force-pushed the vitest-4-missing-tests branch from 279ef5c to 7c9e003 Compare March 22, 2026 22:05
@petebacondarwin petebacondarwin merged commit f9728fd into cloudflare:main Mar 23, 2026
47 of 49 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Mar 23, 2026
Comment thread .changeset/young-knives-sink.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants