Update some missing tests and fixtures with Vitest 4#12999
Merged
Conversation
🦋 Changeset detectedLatest commit: 7c9e003 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Mar 22, 2026
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
I tweaked the PR slightly to simplify the number of changes.
…test-pool-workers-remote-bindings
Contributor
Author
|
@petebacondarwin Thanks a lot, I forgot that 😆 |
Contributor
Author
Contributor
|
I think it is because |
Contributor
|
Some other PR probably broke that but we have benefitted from cached build results, perhaps |
0b11dfd to
a66ec36
Compare
petebacondarwin
approved these changes
Mar 22, 2026
a66ec36 to
279ef5c
Compare
279ef5c to
7c9e003
Compare
petebacondarwin
approved these changes
Mar 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Re #12947.
Migrate more outdated tests and fixtures to Vitest 4 and vpw 0.13.x