[miniflare] Fix requests failing after 5 minutes due to undici Pool default timeouts#13015
Merged
Merged
Conversation
…r local dev Miniflare's undici Pool instances were inheriting the default 300s (5 minute) headersTimeout and bodyTimeout. Requests taking longer than that — streaming responses, large uploads, long-polling, or compute-heavy Workers — would be killed with a 'request failed' error. Setting both to 0 disables them entirely, consistent with the existing pattern in dev-registry.worker.ts where Node.js HTTP server timeouts are also disabled for the same reason. Fixes #12949
🦋 Changeset detectedLatest commit: cdd8e51 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
Contributor
|
The change is straightforward, correct, and complete:
LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
dario-piotrowicz
approved these changes
Mar 23, 2026
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12949.
Miniflare's two
undiciPoolinstances (the main runtime dispatcher inindex.tsand the sync proxy dispatcher infetch-sync.ts) were created without any timeout configuration, causing them to silently inherit undici's defaultheadersTimeoutandbodyTimeoutof 300,000 ms (5 minutes).Any request taking longer than 5 minutes — streaming responses, large uploads, long-polling, or compute-heavy Workers — would be killed by undici with a "request failed" error.
Setting both timeouts to
0disables them entirely. This is the correct behaviour for a local development tool, and is consistent with the existing pattern indev-registry.worker.tswhere Node.js HTTP server timeouts are explicitly disabled for the same reason (long-lived WebSocket connections).