Skip to content

[wrangler] Fix R2 e2e snapshot for data catalog confirmation prompt#13059

Merged
petebacondarwin merged 1 commit intomainfrom
fix/r2-e2e-snapshot-update
Mar 25, 2026
Merged

[wrangler] Fix R2 e2e snapshot for data catalog confirmation prompt#13059
petebacondarwin merged 1 commit intomainfrom
fix/r2-e2e-snapshot-update

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Mar 25, 2026

Fixes the R2 e2e test broken by #12852.

#12852 added a confirmation prompt to r2 bulk put for operations that could affect data catalog state. In non-interactive contexts (like e2e tests), this prompt auto-confirms with a fallback "yes". The batch create objects e2e test snapshot was not updated to include this new output, causing the test to fail.

This updates the inline snapshot to expect the new confirmation prompt lines.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test-only change

Open with Devin

Update the 'batch create objects' e2e test snapshot to include the
new confirmation prompt added in #12852 for operations that could
affect R2 data catalog state.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: faaa195

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 25, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 25, 2026

The change is straightforward and correct. The snapshot adds two lines that match the expected output from the confirmation prompt introduced in PR #12852: the prompt question and the non-interactive fallback message. This is consistent with the same prompt text used in unit tests (src/__tests__/r2/bulk.test.ts) and the source (src/r2/object.ts).

LGTM

github run

Copy link
Copy Markdown
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🙏🏼

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 25, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 25, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13059

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13059

miniflare

npm i https://pkg.pr.new/miniflare@13059

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13059

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13059

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13059

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13059

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13059

wrangler

npm i https://pkg.pr.new/wrangler@13059

commit: faaa195

@petebacondarwin petebacondarwin merged commit 8c08b3f into main Mar 25, 2026
62 of 98 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 25, 2026
@petebacondarwin petebacondarwin deleted the fix/r2-e2e-snapshot-update branch March 25, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants