Skip to content

[vitest-pool-workers] Suppress outputGateBroken stderr noise when testing Workflows#13069

Merged
penalosa merged 2 commits intomainfrom
penalosa/vitest-12764
Mar 30, 2026
Merged

[vitest-pool-workers] Suppress outputGateBroken stderr noise when testing Workflows#13069
penalosa merged 2 commits intomainfrom
penalosa/vitest-12764

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Mar 26, 2026

Fixes #12764.

When testing Cloudflare Workflows with introspectWorkflowInstance, workerd emits broken.outputGateBroken; jsg.Error: Instance dispose to stderr during test teardown as the Durable Object backing the Workflow instance is disposed. This is normal workerd behaviour — the output gate is broken as part of DO cleanup — but it was being forwarded to the user's stderr, adding noise to test output and CI logs.

The existing ignoreMessages filter in handleRuntimeStdio already suppresses similar known-benign workerd messages. This PR adds "broken.outputGateBroken; jsg.Error: Instance dispose" to that list.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: single-line filter addition matching an existing suppression pattern; the reproduction repo in the issue can be used to verify manually
  • Public documentation
    • Documentation not necessary because: internal noise suppression, no user-facing API change

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 972101b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

⚠️ Issues found

File: .changeset/vitest-outputgate-noise.md

Issue: Missing body in changeset description

The changeset contains only a title line with no body:

fix: suppress `outputGateBroken` stderr noise when testing Workflows

Per the README guidelines, the message format requires:

BODY: One or more paragraphs explaining the reason for the change and anything notable about the approach. Aim for more than one sentence but less than three paragraphs to keep it succinct and useful.

The description should explain:

  • What outputGateBroken is and why it was producing noise
  • What caused the spurious stderr output
  • How it was fixed

The title alone is not sufficient. See the patch example in the README for reference:

Fix wrangler dev failing to start when wrangler.toml contains Unicode characters

Previously, projects with non-ASCII characters in configuration values would fail with "Invalid UTF-8 sequence". This is now handled correctly.


Everything else looks fine:

  • Version type (patch) is appropriate for a bug fix
  • No h1/h2/h3 headers present
  • Package (@cloudflare/vitest-pool-workers) is correct for a Workflows testing fix

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 26, 2026

LGTM

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 26, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13069

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13069

miniflare

npm i https://pkg.pr.new/miniflare@13069

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13069

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13069

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13069

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13069

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13069

wrangler

npm i https://pkg.pr.new/wrangler@13069

commit: 972101b

Comment thread packages/vitest-pool-workers/src/pool/index.ts Outdated
@penalosa penalosa marked this pull request as ready for review March 27, 2026 01:08
@penalosa penalosa requested a review from a team as a code owner March 27, 2026 01:08
@penalosa penalosa requested a review from NuroDev March 27, 2026 01:08
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 27, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 30, 2026
@penalosa penalosa merged commit 6d0e329 into main Mar 30, 2026
50 of 55 checks passed
@penalosa penalosa deleted the penalosa/vitest-12764 branch March 30, 2026 12:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 30, 2026
NuroDev pushed a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

vitest-pool-workers: outputGateBroken stderr noise when testing Workflows

3 participants