Skip to content

[vitest-pool-workers] Suppress CODE_MOVED log spam from workerd#13070

Merged
penalosa merged 5 commits intomainfrom
penalosa/vitest-12685
Mar 30, 2026
Merged

[vitest-pool-workers] Suppress CODE_MOVED log spam from workerd#13070
penalosa merged 5 commits intomainfrom
penalosa/vitest-12685

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Mar 26, 2026

Fixes #12685.

Miniflare's structured log handler already filters CODE_MOVED for unknown code block messages (an internal workerd diagnostic), but vitest-pool-workers uses a custom handleRuntimeStdio callback that bypasses the structured logs pipeline and pipes stderr directly to process.stderr. This adds the pattern to the pool's own ignore list.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: The change adds a string to an existing ignore list — the filtering mechanism is already well-tested by the existing entries.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal log filtering, no user-facing API change.

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 5ae4e08

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

✅ All changesets look good

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 26, 2026

The change is straightforward, correct, and consistent with how Miniflare already filters the same message. The string used ("CODE_MOVED for unknown code block") matches the pattern in Miniflare's structured-logs.ts. The filtering mechanism (.some((message) => str.includes(message))) is already in use and well-tested by the existing entries.

LGTM

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 26, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13070

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13070

miniflare

npm i https://pkg.pr.new/miniflare@13070

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13070

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13070

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13070

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13070

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13070

wrangler

npm i https://pkg.pr.new/wrangler@13070

commit: 5ae4e08

@penalosa penalosa marked this pull request as ready for review March 27, 2026 01:07
@penalosa penalosa requested a review from a team as a code owner March 27, 2026 01:07
@penalosa penalosa requested a review from vicb March 27, 2026 01:07
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 27, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Comment thread packages/vitest-pool-workers/src/pool/index.ts Outdated
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 30, 2026
@penalosa penalosa merged commit cdb9c88 into main Mar 30, 2026
48 checks passed
@penalosa penalosa deleted the penalosa/vitest-12685 branch March 30, 2026 13:32
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

@cloudflare/vitest-pool-workers broken in macOS after upgrade

3 participants