[miniflare] Make temp directory cleanup best-effort in dispose()

[penalosa]

Fixes #10511.

On Windows, workerd may not release file handles immediately after Runtime#dispose() returns. When Miniflare#dispose() then tries to remove the temp directory, fs.promises.rm fails with EBUSY — and because this isn't caught, the error propagates to the caller (e.g. vitest-pool-workers), producing noisy errors in test output.

The temp directory lives in os.tmpdir(), so the OS will clean it up eventually. This makes the async cleanup path best-effort — matching the pattern the synchronous exit hook already uses.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because: this is a Windows-specific error handling change — the cleanup itself is unchanged, it just no longer throws on failure
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal behaviour change

---

[changeset-bot]

🦋 Changeset detected

Latest commit: 2e0ee78

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

✅ All changesets look good

[ask-bonk]

The change is clean and correct. Let me verify my understanding:

1. The synchronous exit hook (line 1067-1070) already catches errors and logs them at debug level.
2. The async dispose() method now wraps removeDir in a try/catch too, but silently swallows the error (empty catch {}).

The only minor observation is that the sync exit hook logs the error at debug level (this.#log.debug(...)) while the async path silently swallows it. However, this is a pragmatic choice — the PR description explicitly notes this is about suppressing noisy errors, and the context in dispose() is that cleanup is already happening. The empty catch is defensible here since:

• The temp directory is in os.tmpdir() and will be cleaned up by the OS.
• The error is expected (EBUSY on Windows) and not indicative of a real problem.
• Adding a debug log would be nice for consistency but isn't actionable.

The changeset is properly formatted as a patch for miniflare, and the description is clear.

This is a straightforward, well-motivated fix. No logic bugs, no security issues, no backward compatibility concerns.

LGTM

github run

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13078

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13078

miniflare

npm i https://pkg.pr.new/miniflare@13078

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13078

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13078

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13078

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13078

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13078

wrangler

npm i https://pkg.pr.new/wrangler@13078

commit: 2e0ee78

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.