[miniflare] Fix glob patterns matching double-extension filenames#13080
Merged
[miniflare] Fix glob patterns matching double-extension filenames#13080
Conversation
🦋 Changeset detectedLatest commit: b85adb9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
Contributor
|
The fix is clean, correct, and well-tested. Let me verify the logic once more:
The unit tests cover both positive and negative cases. The fixture test provides an integration-level regression test. The changeset is correctly scoped to LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
jamesopstad
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8280.
globsToRegExpscompiles glob patterns usingglob-to-regexpwithflags: "g", which strips both^and$anchors. The code already reconstructed each regex without thegflag, but didn't restore$— so a pattern like**/*.wasmwould match any path containing.wasmas a substring, includingfoo.wasm.jsormain.wasm.test.ts.This primarily affects
@cloudflare/vitest-pool-workersusers with awrangler.configPathset, since Wrangler's default module rules include{ type: "CompiledWasm", globs: ["**/*.wasm"] }. Test files with.wasmin their name (e.g.main.wasm.test.ts) would be incorrectly tagged as WebAssembly modules and fail to load.The fix appends
$to each compiled regex source. The leading^stays absent — this is intentional so patterns can match anywhere within an absolute path.