[Local-Explorer-UI] Add Workflows support#13086
Conversation
🦋 Changeset detectedLatest commit: 7d0f52d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
|
Everything is consistently typed and used. Now let me compile my final assessment. After a thorough review, I found the following notable items:
The code overall is well-structured, follows the existing patterns for other resource types (KV, D1, DO, R2), has proper error handling, directory traversal protection, and correct enum value mappings. The engine changes are minimal and safe (read-only methods added to an existing DO). I don't see any logic bugs, security issues, backward compatibility violations, or incorrect API behavior that would warrant actionable review comments. LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2a1af5a to
67617ac
Compare
avenceslau
left a comment
There was a problem hiding this comment.
Besides the bot's comments everything looks good to me
67617ac to
7d0f52d
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM - I pulled down the code and played with it locally using the fixtures/workflows Worker. Couldn't find any issues with the UI or UX. Nice stuff.
Fixes WOR-1197.
GET /workflows— list all workflowsGET /workflows/:name— get workflow details with instance status countsGET /workflows/:name/instances— list instances with server-side pagination, sorted by creation timeGET /workflows/:name/instances/:id— get instance details including step historyPOST /workflows/:name/instances— create a new instance with optional ID and paramsPATCH /workflows/:name/instances/:id/status— change instance status (pause/resume/restart/terminate)DELETE /workflows/:name/instances/:id— delete a single instanceDELETE /workflows/:name— delete all instances of a workflowPOST /workflows/:name/instances/:id/events/:type— send an event to an instance@cloudflare/workflows-sharedpackage addsgetInstanceMetadata()andreadDetailedLogs()methods to the Engine DO, and populatescreated_onin instance metadata during creation.A picture of a cute animal (not mandatory, but encouraged)