[vitest-pool-workers] Bump RTTI compat date#13091
Conversation
🦋 Changeset detectedLatest commit: 3632bc6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2e34ff5 to
9eabcd1
Compare
|
I've reviewed the full PR thoroughly. Here's my analysis:
Both changes are straightforward, correct, and well-scoped. No logic bugs, no security concerns, no backward compatibility issues. LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
9eabcd1 to
cceedd1
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
✅ All changesets look good |
The RTTI query used to build
workerdBuiltinModuleswas hardcoded to compat date"2023-12-01", meaning any Node.js modules added to workerd in the last 2+ years weren't recognized as builtins. This caused the module fallback service to reject them with "Not found" instead of routing to workerd's native implementation.This PR replaces the hardcoded date with today's date at build time, so
workerdBuiltinModulesautomatically stays in sync with the bundled workerd version on each rebuild.