[vitest-pool-workers] Reject V8 coverage provider with a clear error#13095
Merged
[vitest-pool-workers] Reject V8 coverage provider with a clear error#13095
Conversation
🦋 Changeset detectedLatest commit: 1460c3c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
✅ All changesets look good |
Contributor
|
UnknownError: "Internal server error" |
Contributor
|
@penalosa Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
penalosa
force-pushed
the
penalosa/vitest-5266
branch
from
4e6d014 to
ecbbd26
Compare
edmundhung
reviewed
Mar 30, 2026
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
LGTM, besides what Edmund already commented on
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
V8 native coverage requires node:inspector which is non-functional in workerd. Detect this early in the Vite plugin config hook and throw a clear error directing users to Istanbul coverage instead. Fixes #5266
penalosa
force-pushed
the
penalosa/vitest-5266
branch
from
10f5dca to
1460c3c
Compare
edmundhung
approved these changes
Apr 2, 2026
workers-devprod
approved these changes
Apr 2, 2026
Contributor
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5266.
V8 native coverage (
@vitest/coverage-v8) requiresnode:inspectorto collect profiling data from V8's runtime. workerd providesnode:inspectoras a non-functional stub — methods are no-ops,url()returns undefined — so V8 coverage silently fails or crashes with a confusingNo such module "node:inspector"error.This adds early detection in the Vite plugin
confighook, which runs before Vitest attempts to resolve the@vitest/coverage-v8package. When coverage is enabled with thev8provider (or no provider, since v8 is the default), the plugin throws a clear error directing users to use Istanbul coverage instead.Istanbul works by instrumenting source code at build time and doesn't need
node:inspector, so it runs on any JavaScript runtime including workerd.