Skip to content

IMAGES-2139: temporarily skip images hosted CRUD tests#13124

Merged
petebacondarwin merged 2 commits intocloudflare:mainfrom
mglewis:mattl/IMAGES-2139-skip-hosted-crud-tests
Mar 30, 2026
Merged

IMAGES-2139: temporarily skip images hosted CRUD tests#13124
petebacondarwin merged 2 commits intocloudflare:mainfrom
mglewis:mattl/IMAGES-2139-skip-hosted-crud-tests

Conversation

@mglewis
Copy link
Copy Markdown
Member

@mglewis mglewis commented Mar 30, 2026

Tests are skipped pending the workerd API change in cloudflare/workerd#6288. We are unable to merge the workerd change with these tests being run (and subsequently failing).

This functionality is currently gated to my internal account, so no user impact.


  • Tests
    • Tests included/updated
    • Automated tests not possible
    • Additional testing not necessary because: we are only skipping a test on an unreleased feature
  • Public documentation
    • Cloudflare docs PR(s): Not required
    • Documentation not necessary because: we are only temporarily skipping a test

A picture of a cute animal (not mandatory, but encouraged)
Baby quokka:
image


Open with Devin

Tests are skipped pending the workerd API change in
cloudflare/workerd#6288
@mglewis mglewis requested a review from a team as a code owner March 30, 2026 14:59
@mglewis mglewis requested a review from jamesopstad March 30, 2026 14:59
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

🦋 Changeset detected

Latest commit: 8482015

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/test/plugins/images/index.spec.ts: [@cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 30, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13124

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13124

miniflare

npm i https://pkg.pr.new/miniflare@13124

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13124

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13124

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13124

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13124

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13124

wrangler

npm i https://pkg.pr.new/wrangler@13124

commit: 8482015

@mglewis mglewis force-pushed the mattl/IMAGES-2139-skip-hosted-crud-tests branch from b0b957d to 8977453 Compare March 30, 2026 18:10
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 30, 2026
@petebacondarwin petebacondarwin merged commit 53dd863 into cloudflare:main Mar 30, 2026
46 of 50 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants