fix(vite-plugin): prevent SyntaxError when SSR module ends with // comment#13125
Merged
jamesopstad merged 2 commits intocloudflare:mainfrom Apr 1, 2026
Merged
Conversation
…mment
When module code produced by the SSR transform ends with a single-line
comment (e.g. `//# sourceMappingURL=...` preserved by vite-plus), the
closing `}` of the async arrow wrapper in `runInlinedModule` gets
absorbed into the comment:
"use strict";async (...)=>{...//# sourceMappingURL=foo.js.map}
This produces an unclosed function body and throws
`SyntaxError: Unexpected end of input`.
Fix: insert a newline before the closing brace so it always starts a
new line, safe from trailing `//` comments.
Fixes cloudflare#12681
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 50d2c47 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
penalosa
approved these changes
Mar 30, 2026
Contributor
penalosa
left a comment
There was a problem hiding this comment.
I'm pretty certain this is a bug in Vite plus, but this workaround seems okay
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Merged
emily-shen
pushed a commit
that referenced
this pull request
Apr 8, 2026
…mment (#13125) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When module code produced by the SSR transform ends with a single-line comment (e.g.
//# sourceMappingURL=...preserved byvite-plus), the closing}of the async arrow wrapper inrunInlinedModulegets absorbed into the comment:This produces an unclosed function body and throws
SyntaxError: Unexpected end of input.Fix
Insert a newline before the closing brace so it always starts a new line, safe from trailing
//comments:This is backwards-compatible — the newline is harmless when there is no trailing comment.
Reproduction
Use
@cloudflare/vite-pluginwithvite-plus(which preserves sourceMappingURL comments in SSR-transformed output, unlike standard Vite which strips them).Fixes #12681