Skip to content

[wrangler] Fix versions e2e test snapshots after #13072#13127

Closed
petebacondarwin wants to merge 1 commit intomainfrom
fix-versions-e2e-snapshots
Closed

[wrangler] Fix versions e2e test snapshots after #13072#13127
petebacondarwin wants to merge 1 commit intomainfrom
fix-versions-e2e-snapshots

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Mar 30, 2026

Fixes the e2e test snapshots in versions.test.ts that were broken by #13072.

PR #13072 changed the status message from "Fetching deployable versions" to "Fetching versions" when no specific version IDs are provided, but the e2e test snapshots were not updated to match.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this PR only fixes existing test snapshots
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test-only change

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 99c57c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/wrangler/e2e/versions.test.ts: [@cloudflare/wrangler]

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 30, 2026

The diff is clear. The only meaningful change across both snapshot blocks is "Fetching deployable versions""Fetching versions", which matches the behavior change from PR #13072. The rest of the diff is just indentation adjustments (likely from a snapshot re-record).

LGTM

github run

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 30, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13127

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13127

miniflare

npm i https://pkg.pr.new/miniflare@13127

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13127

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13127

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13127

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13127

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13127

wrangler

npm i https://pkg.pr.new/wrangler@13127

commit: 99c57c5

@petebacondarwin petebacondarwin removed the request for review from vicb March 30, 2026 19:29
@petebacondarwin
Copy link
Copy Markdown
Contributor Author

Landed as part of #13111

@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants