[explorer] add local explorer hotkey to the vite plugin#13137
Conversation
🦋 Changeset detectedLatest commit: 9231b24 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
✅ All changesets look good |
bc8e89a to
c2e5e43
Compare
|
I've now thoroughly reviewed all the changes. Let me summarize my findings: The implementation is clean and follows existing patterns well. The code:
The only thing I notice is not really an issue but worth noting: in wrangler, the explorer hotkey has its label intentionally hidden (commented out) to keep it secret before announcement, while the vite plugin has a visible LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Co-authored-by: Ben Dixon <ben@nuro.dev> Co-authored-by: Ben <4991309+NuroDev@users.noreply.github.com>
Co-authored-by: Ben Dixon <ben@nuro.dev> Co-authored-by: Ben <4991309+NuroDev@users.noreply.github.com>
this uses
elike in wrangler, which doesn't conflict with any default vite hotkeys.vite doesn't have a way of hiding bindings, so this should not be merged until we are ready to properly announce this.
Also, we seem to use
openin c3 and wrangler to open browsers, so i've used it here too in the vite plugin, and added it to the pnpm catalog and updated the version from 8 -> 11. open v11 is ESM only, but it seems fine? I vaguely remember we have tried to move off as many CJS packages as possible, not sure if this was skipped on purpose.A picture of a cute animal (not mandatory, but encouraged)