Add gitignore-like helpers to cli package and remove old duplicated logic from c3 and autoconfig#13144
Merged
dario-piotrowicz merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
|
✅ All changesets look good |
🦋 Changeset detectedLatest commit: e1930dd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
…ogic from c3 and autoconfig
3566058 to
e1930dd
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
petebacondarwin
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.cfdata.org/browse/DEVX-2380
We have some duplicated autoconfig logic that appends wrangler stuff to
.gitignoreand.assetsignore, this logic is also present in C3. This PR is de-duplicating the logic so that there is only a single function that includes it (maybeAppendWranglerToGitIgnoreLikeFile) and this function is moved to the cli package and used by both C3 and autoconfig.(Additionally there's also a trivial
maybeAppendWranglerToGitIgnorewrapper that also checks that the.gitdir exists)A picture of a cute animal (not mandatory, but encouraged)