Skip to content

Add gitignore-like helpers to cli package and remove old duplicated logic from c3 and autoconfig#13144

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2380/3/remove-c3-vendor
Mar 31, 2026
Merged

Add gitignore-like helpers to cli package and remove old duplicated logic from c3 and autoconfig#13144
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2380/3/remove-c3-vendor

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Mar 31, 2026

Fixes https://jira.cfdata.org/browse/DEVX-2380

We have some duplicated autoconfig logic that appends wrangler stuff to .gitignore and .assetsignore, this logic is also present in C3. This PR is de-duplicating the logic so that there is only a single function that includes it (maybeAppendWranglerToGitIgnoreLikeFile) and this function is moved to the cli package and used by both C3 and autoconfig.

(Additionally there's also a trivial maybeAppendWranglerToGitIgnore wrapper that also checks that the .git dir exists)


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

✅ All changesets look good

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: e1930dd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13144

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13144

miniflare

npm i https://pkg.pr.new/miniflare@13144

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13144

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13144

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13144

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13144

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13144

wrangler

npm i https://pkg.pr.new/wrangler@13144

commit: e1930dd

ask-bonk[bot]

This comment was marked as outdated.

@ask-bonk

This comment was marked as outdated.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/3/remove-c3-vendor branch from 3566058 to e1930dd Compare March 31, 2026 15:17
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 31, 2026 15:38
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 31, 2026 15:38
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 31, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 31, 2026
@dario-piotrowicz dario-piotrowicz merged commit db60b94 into main Mar 31, 2026
51 of 56 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2380/3/remove-c3-vendor branch March 31, 2026 20:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants