Skip to content

Polish Cloudflare Vite plugin installation during autoconfig#13150

Merged
dario-piotrowicz merged 5 commits intomainfrom
dario/DEVX-2509/autoconfig-vite-improvements
Apr 1, 2026
Merged

Polish Cloudflare Vite plugin installation during autoconfig#13150
dario-piotrowicz merged 5 commits intomainfrom
dario/DEVX-2509/autoconfig-vite-improvements

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Mar 31, 2026

Fixes https://jira.cfdata.org/browse/DEVX-2509

Projects using Vite 6.0.x were rejected by auto-configuration because the minimum supported version was set to 6.1.0 (the @cloudflare/vite-plugin peer dependency). The minimum version check is now 6.0.0, and when a project has Vite in the [6.0.0, 6.1.0) range, auto-configuration will automatically upgrade it to the latest 6.x before installing @cloudflare/vite-plugin.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self-explanatory behavior

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 6c74c10

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

✅ All changesets look good

ask-bonk[bot]

This comment was marked as outdated.

@ask-bonk

This comment was marked as outdated.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2509/autoconfig-vite-improvements branch from f1164c8 to 3b726c9 Compare March 31, 2026 17:35
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2509/autoconfig-vite-improvements branch from 3b726c9 to be349e0 Compare March 31, 2026 17:39
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13150

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13150

miniflare

npm i https://pkg.pr.new/miniflare@13150

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13150

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13150

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13150

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13150

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13150

wrangler

npm i https://pkg.pr.new/wrangler@13150

commit: 6c74c10

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 31, 2026 18:21
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 31, 2026 18:21
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 31, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but LGTM

Comment thread packages/wrangler/src/autoconfig/frameworks/all-frameworks.ts
Comment thread packages/wrangler/src/autoconfig/frameworks/utils/vite-plugin.ts Outdated
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 31, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz merged commit 4dc94fd into main Apr 1, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 1, 2026
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2509/autoconfig-vite-improvements branch April 1, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants