Remove lint consistent-type-imports override (to off) for miniflare#13250
Merged
dario-piotrowicz merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
|
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
5 tasks
Member
Author
|
Note This PR is a copy of #13183, there the devprod bot is not approving the PR for some reason so I am trying to see if the bot does work here... |
penalosa
previously approved these changes
Apr 2, 2026
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Contributor
|
LGTM |
ascorbic
approved these changes
Apr 2, 2026
Contributor
|
Codeowners bypass |
workers-devprod
approved these changes
Apr 2, 2026
Contributor
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a set of lint overrides for miniflare that we should get rid of:
workers-sdk/.oxlintrc.jsonc
Line 123 in fb67a18
I think it makes sense to try to gradually get rid of those instead of trying to remove them all in one go.
In this PR I am getting rid of the
consistent-type-importsone, re-aligning miniflare with the rest of the codebase.A picture of a cute animal (not mandatory, but encouraged)