Skip to content

Remove lint consistent-type-imports override (to off) for miniflare#13250

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/enable-consistent-type-imports-in-miniflare-1
Apr 2, 2026
Merged

Remove lint consistent-type-imports override (to off) for miniflare#13250
dario-piotrowicz merged 1 commit intomainfrom
dario/enable-consistent-type-imports-in-miniflare-1

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 2, 2026

We have a set of lint overrides for miniflare that we should get rid of:

// TODO: remove these overrides. This is a legacy of Miniflare's history, not intentional

I think it makes sense to try to gradually get rid of those instead of trying to remove them all in one go.

In this PR I am getting rid of the consistent-type-imports one, re-aligning miniflare with the rest of the codebase.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: simple code refactoring
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: simple code refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

⚠️ No Changeset found

Latest commit: dd441ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 2, 2026
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team April 2, 2026 11:15
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 2, 2026

Codeowners approval required for this PR:

  • @cloudflare/workers-kv
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/workers/kv/constants.ts: [@cloudflare/workers-kv]
  • packages/miniflare/src/workers/kv/namespace.worker.ts: [@cloudflare/workers-kv]
  • packages/miniflare/src/workers/kv/sites.worker.ts: [@cloudflare/workers-kv]
  • packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]

@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Note

This PR is a copy of #13183, there the devprod bot is not approving the PR for some reason so I am trying to see if the bot does work here...

penalosa
penalosa previously approved these changes Apr 2, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13250

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13250

miniflare

npm i https://pkg.pr.new/miniflare@13250

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13250

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13250

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13250

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13250

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13250

wrangler

npm i https://pkg.pr.new/wrangler@13250

commit: dd441ff

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 2, 2026

LGTM

github run

@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Apr 2, 2026

Codeowners bypass

@penalosa penalosa dismissed their stale review April 2, 2026 12:45

stale

Copy link
Copy Markdown
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners Bypass

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 2, 2026
Merged via the queue into main with commit 0f32348 Apr 2, 2026
128 of 132 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/enable-consistent-type-imports-in-miniflare-1 branch April 2, 2026 13:09
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants