[wrangler] fix: resolve named service entrypoints for env-scoped workers#13313
Closed
swalker326 wants to merge 1 commit intocloudflare:mainfrom
Closed
[wrangler] fix: resolve named service entrypoints for env-scoped workers#13313swalker326 wants to merge 1 commit intocloudflare:mainfrom
swalker326 wants to merge 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 8951cb8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
ascorbic
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
seems to have been fixed with v 4.80.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up the env-qualified secondary worker resolution fix from #13061 for the named
services[].entrypointcase.When
wrangler typesruns across multiple-cconfigs, a secondary worker can expose environment-specific names likesecondary-worker-staging. Bindings targeting those env-qualified names were already resolvable for the default worker entrypoint, but namedWorkerEntrypointbindings could still fall back to an unresolved type comment instead of emittingService<typeof import(...).SomeEntrypoint>.This change registers each secondary worker's env-qualified name against that env's resolved
Entrymetadata, so named service entrypoints keep the correct source module and export information during type generation.