Skip to content

feat(local-explorer): Switch local explorer to use Kumo sidebar#13330

Merged
jamesopstad merged 42 commits intomainfrom
NuroDev/local-explorer-sidebar
Apr 10, 2026
Merged

feat(local-explorer): Switch local explorer to use Kumo sidebar#13330
jamesopstad merged 42 commits intomainfrom
NuroDev/local-explorer-sidebar

Conversation

@NuroDev
Copy link
Copy Markdown
Member

@NuroDev NuroDev commented Apr 7, 2026

Fixes DEVX-2539.

Summary

  • Upgrades @cloudflare/kumo to version 1.17.0
  • Renames the core app sidebar component from Sidebar to AppSidebar
  • Replaced the core app sidebar component logic with the Sidebar component from @cloudflare/kumo
    • Now support compact sidebar mode (State persisted in local storage)
    • Now supports theme switching (State persisted in local storage)
    • In compact mode, item groups use a popover to list items
  • Minor code formatting fixes
  • Added strictly typed worker search parameter to all routes
  • Fixed broken behaviour tests (main branch seems to have broken)

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: WIP Experimental feature

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@NuroDev NuroDev self-assigned this Apr 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: 95aa5ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

✅ All changesets look good

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 7, 2026

Review posted successfully on PR #13330.

I found one actionable bug: the expanded sidebar mode silently drops error messages. The old SidebarItemGroup had a three-way branch (error → show error text, no error + no items → show empty label, no error + items → render links), but the new collapsible content only has a two-way branch that omits the error case. When an API call fails, users will see a blank collapsible group with no indication of what went wrong. I posted a suggestion to restore the three-way conditional matching the old behavior and the compact-mode popup's pattern.

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 7, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13330

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13330

miniflare

npm i https://pkg.pr.new/miniflare@13330

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13330

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13330

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13330

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13330

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13330

wrangler

npm i https://pkg.pr.new/wrangler@13330

commit: 95aa5ed

Comment thread packages/local-explorer-ui/src/routes/__root.tsx
@NuroDev NuroDev marked this pull request as ready for review April 10, 2026 08:56
@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team April 10, 2026 08:56
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 10, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pulled it down and played around. Changes seem good. Thanks!

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 10, 2026
@jamesopstad jamesopstad merged commit b30eb67 into main Apr 10, 2026
93 of 101 checks passed
@jamesopstad jamesopstad deleted the NuroDev/local-explorer-sidebar branch April 10, 2026 18:32
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants