Skip to content

chore(local-explorer-ui): Fix E2E test flake-y-ness#13448

Merged
petebacondarwin merged 10 commits intomainfrom
NuroDev/local-explorer-fix-e2e-ci
Apr 13, 2026
Merged

chore(local-explorer-ui): Fix E2E test flake-y-ness#13448
petebacondarwin merged 10 commits intomainfrom
NuroDev/local-explorer-fix-e2e-ci

Conversation

@NuroDev
Copy link
Copy Markdown
Member

@NuroDev NuroDev commented Apr 13, 2026

Fixes N/A.

Summary

This includes a number of smaller tweaks and changes to try and prevent some of the recent issues we have seen where the LE E2E tests have been failing due to timeouts in CI. This includes:

  • Increase workflow total timeout to 30 minutes from 10 minutes
  • Disabled test file parallelism
  • Increased Vitests hook & test timeout specifically when running in CI
  • Switched "page load complete" stage from networkidle to domcontentloaded
  • Tweaked some R2 breadcrumb tests that have been consistently failing
  • Ran the workspace prettify script and fixed a few minor formatting issues with 2 changesets

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Only affects the test suite

A picture of a cute animal (not mandatory, but encouraged)

@NuroDev NuroDev self-assigned this Apr 13, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: 4f458d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 13, 2026
@NuroDev NuroDev marked this pull request as ready for review April 13, 2026 08:37
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team April 13, 2026 08:38
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 13, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 13, 2026

The changes are straightforward and sensible. Let me assess each change:

  1. Workflow timeout 10 -> 30 min: The step-level timeout now equals the job-level timeout, making the step timeout redundant. But it was previously 10 which was too tight — this is fine.

  2. fileParallelism: false: Reasonable for flaky E2E tests sharing browser state.

  3. CI-conditional timeouts: Clean approach using process.env.CI.

  4. networkidle -> domcontentloaded: This is the key change for flake reduction. networkidle is notoriously flaky in Playwright. The tests already use explicit waitForText/waitForTableRows after navigation, so domcontentloaded is sufficient.

  5. seedFetch with AbortController: Good improvement — adds timeout and error checking for seed requests that previously had no timeout and silently ignored failures.

Everything looks correct and well-reasoned. No logic bugs, no security issues, no backward compatibility concerns.

LGTM

github run

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 13, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13448

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13448

miniflare

npm i https://pkg.pr.new/miniflare@13448

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13448

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13448

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13448

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13448

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13448

wrangler

npm i https://pkg.pr.new/wrangler@13448

commit: 4f458d9

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed 3 times in a row locally for me.

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 13, 2026
@petebacondarwin petebacondarwin merged commit 92c9cd4 into main Apr 13, 2026
60 of 62 checks passed
@petebacondarwin petebacondarwin deleted the NuroDev/local-explorer-fix-e2e-ci branch April 13, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants