Skip to content

Revert "[wrangler] fix: prevent remote binding sessions expiring during long dev sessions"#13464

Merged
jamesopstad merged 1 commit intomainfrom
revert-13016-penalosa/remote-bindings-timeout
Apr 14, 2026
Merged

Revert "[wrangler] fix: prevent remote binding sessions expiring during long dev sessions"#13464
jamesopstad merged 1 commit intomainfrom
revert-13016-penalosa/remote-bindings-timeout

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad commented Apr 14, 2026

Reverts #13016

The Version Packages PR was failing with an error in a remote e2e test that was not run when reviewing the original PR. See https://github.com/cloudflare/workers-sdk/actions/runs/24370047636/job/71171368260?pr=13461#step:7:593


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: 07caf08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team April 14, 2026 08:38
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 14, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 14, 2026

No difference at all in the test files — the revert perfectly restores the pre-#13016 state.

This is a clean revert of PR #13016. The code exactly matches the pre-#13016 state (modulo unrelated changes from other PRs). There are no logic bugs, type mismatches, or other issues introduced by this revert — it simply restores the previously-known-working code.

LGTM

github run

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 14, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 14, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13464

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13464

miniflare

npm i https://pkg.pr.new/miniflare@13464

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13464

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13464

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13464

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13464

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13464

wrangler

npm i https://pkg.pr.new/wrangler@13464

commit: 07caf08

@petebacondarwin petebacondarwin added run-remote-tests skip-pr-description-validation Skip validation of the required PR description format labels Apr 14, 2026
@jamesopstad jamesopstad merged commit 7d81a83 into main Apr 14, 2026
97 of 106 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 14, 2026
@jamesopstad jamesopstad deleted the revert-13016-penalosa/remote-bindings-timeout branch April 14, 2026 09:34
petebacondarwin pushed a commit that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-remote-tests skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants