Skip to content

fix(wrangler): wrangler preview no longer warns about missing inheritable bindings#13469

Merged
jamesopstad merged 1 commit intocloudflare:mainfrom
1000hz:fix-previews-missing-assets-binding-warning
Apr 14, 2026
Merged

fix(wrangler): wrangler preview no longer warns about missing inheritable bindings#13469
jamesopstad merged 1 commit intocloudflare:mainfrom
1000hz:fix-previews-missing-assets-binding-warning

Conversation

@1000hz
Copy link
Copy Markdown
Contributor

@1000hz 1000hz commented Apr 14, 2026

This PR removes inheritable bindings from the missing bindings warning in wrangler preview.

Currently, this warning incorrectly advises the user to add these bindings to their previews config, but this is not allowed.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Open with Devin

@1000hz 1000hz requested a review from workers-devprod as a code owner April 14, 2026 13:59
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

🦋 Changeset detected

Latest commit: c81f036

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 14, 2026
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team April 14, 2026 13:59
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 14, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 14, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13469

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13469

miniflare

npm i https://pkg.pr.new/miniflare@13469

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13469

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13469

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13469

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13469

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13469

wrangler

npm i https://pkg.pr.new/wrangler@13469

commit: c81f036

Comment thread packages/wrangler/src/preview/preview.ts Outdated
@1000hz 1000hz force-pushed the fix-previews-missing-assets-binding-warning branch from 8508e30 to 997357f Compare April 14, 2026 14:16
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You'll need to rebase as the required checks have changed.

@1000hz 1000hz force-pushed the fix-previews-missing-assets-binding-warning branch from 997357f to c81f036 Compare April 14, 2026 16:11
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 14, 2026
@jamesopstad jamesopstad merged commit 07a918c into cloudflare:main Apr 14, 2026
58 of 59 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 14, 2026
@1000hz 1000hz deleted the fix-previews-missing-assets-binding-warning branch April 15, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants