Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-flagship-remote-entrypoint.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"miniflare": patch
---

Fix `wrangler dev` crash when using a Flagship binding with `remote: true`

In remote mode, the flagship binding is backed by a generic proxy worker that only has a default export. The plugin was requesting a named entrypoint `"FlagshipBinding"` which doesn't exist on it, causing workerd to reject the binding at startup. The named entrypoint is now omitted in remote mode so workerd routes to the default export, which correctly proxies all RPC calls to the remote Flagship service.
4 changes: 3 additions & 1 deletion packages/miniflare/src/plugins/flagship/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ export const FLAGSHIP_PLUGIN: Plugin<typeof FlagshipOptionsSchema> = {
name,
config.remoteProxyConnectionString
),
entrypoint: "FlagshipBinding",
entrypoint: config.remoteProxyConnectionString
? undefined
: "FlagshipBinding",
},
})
);
Expand Down
Loading