[miniflare] Fix Hyperdrive proxy servers not closing on dispose#13520
Closed
petebacondarwin wants to merge 1 commit intomainfrom
Closed
[miniflare] Fix Hyperdrive proxy servers not closing on dispose#13520petebacondarwin wants to merge 1 commit intomainfrom
petebacondarwin wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 352031c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
✅ All changesets look good |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@petebacondarwin Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
Author
|
Superseded by #13515 which includes this fix (missing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dispose()method inHyperdriveProxyControllerwas missing areturnstatement in its.map()callback, so the Promises fromserver.close()were never passed toPromise.allSettled(). This meant the proxynet.Serverinstances were never actually waited on to close, potentially keeping the Node.js event loop alive and contributing towrangler devhanging on Ctrl-C.return); existing Hyperdrive tests confirm no regression