Skip to content

[miniflare] Fix Hyperdrive proxy servers not closing on dispose#13520

Closed
petebacondarwin wants to merge 1 commit intomainfrom
fix/hyperdrive-proxy-dispose
Closed

[miniflare] Fix Hyperdrive proxy servers not closing on dispose#13520
petebacondarwin wants to merge 1 commit intomainfrom
fix/hyperdrive-proxy-dispose

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Apr 15, 2026

The dispose() method in HyperdriveProxyController was missing a return statement in its .map() callback, so the Promises from server.close() were never passed to Promise.allSettled(). This meant the proxy net.Server instances were never actually waited on to close, potentially keeping the Node.js event loop alive and contributing to wrangler dev hanging on Ctrl-C.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: one-word fix (missing return); existing Hyperdrive tests confirm no regression
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal implementation fix with no user-facing API change

Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 352031c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 15, 2026
@workers-devprod workers-devprod requested review from a team and dario-piotrowicz and removed request for a team April 15, 2026 15:30
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/plugins/hyperdrive/hyperdrive-proxy.ts: [@cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-actions
Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 15, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13520

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13520

miniflare

npm i https://pkg.pr.new/miniflare@13520

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13520

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13520

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13520

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13520

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13520

wrangler

npm i https://pkg.pr.new/wrangler@13520

commit: 352031c

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 15, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 15, 2026

@petebacondarwin Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@petebacondarwin
Copy link
Copy Markdown
Contributor Author

Superseded by #13515 which includes this fix (missing return in .map() callback in HyperdriveProxyController.dispose()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants