[miniflare] Close runtime WebSocket in InspectorProxy dispose#13522
[miniflare] Close runtime WebSocket in InspectorProxy dispose#13522petebacondarwin wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 763b66c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
The change is straightforward and correct:
LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
✅ All changesets look good Summary of changesets reviewed:
All changesets:
|
|
Superseded by #13515 which includes this fix (closing |
InspectorProxy.dispose()was closing the devtools WebSocket connection but not the runtime WebSocket connection to workerd's inspector server. The open runtime WebSocket (and its 10-second keep-alive interval, which was correctly cleared) kept the socket alive, preventing the Node.js event loop from draining and contributing towrangler devhanging on Ctrl-C.