[miniflare] Force-close connections in InspectorProxyController dispose#13523
Closed
petebacondarwin wants to merge 1 commit intomainfrom
Closed
[miniflare] Force-close connections in InspectorProxyController dispose#13523petebacondarwin wants to merge 1 commit intomainfrom
petebacondarwin wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0bd94a8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
The change is straightforward and correct. The LGTM |
Contributor
|
✅ All changesets look good |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
added a commit
that referenced
this pull request
Apr 16, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
Contributor
Author
|
Folded into #13515 which now includes this fix ( |
3 tasks
petebacondarwin
added a commit
that referenced
this pull request
Apr 16, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
petebacondarwin
added a commit
that referenced
this pull request
Apr 16, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
petebacondarwin
added a commit
that referenced
this pull request
Apr 17, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
petebacondarwin
added a commit
that referenced
this pull request
Apr 17, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
petebacondarwin
added a commit
that referenced
this pull request
Apr 17, 2026
…ispose Fold in fix from PR #13523: call server.closeAllConnections() before server.close() so active HTTP keep-alive or WebSocket connections don't prevent the close callback from firing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InspectorProxyController.dispose()was callingserver.close()without first callingserver.closeAllConnections(). Active HTTP keep-alive or WebSocket connections would prevent theclosecallback from firing, hanging the dispose indefinitely and contributing towrangler devnot exiting on Ctrl-C.The same file's
#closeServer()method (used during port changes viasetOptions()) already usescloseAllConnections()— this bringsdispose()in line with that pattern.#closeServer()pattern in the same file; existing inspector proxy tests confirm no regression