Conversation
do we need this fixture any more?
🦋 Changeset detectedLatest commit: 37a5e60 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note this file does NOT have the I've now thoroughly reviewed the entire PR. Here's my assessment: The changes are a straightforward, mechanical migration of test fixtures from There are no logic bugs, security issues, or backward compatibility violations. The only very minor issue is duplicate imports from the same module in one file, but this is a nitpick on a fixture file -- it's not even a formatting issue since it's functionally valid. I don't consider this actionable. LGTM |
27a1b00 to
0617588
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
edmundhung
left a comment
There was a problem hiding this comment.
Approved with an assumption that you will either add a changeset or remove the fix from this PR.
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
cb1934a to
37a5e60
Compare
Changeset ReviewSummary✅ All changesets look good Reviewed Changesetsclear-turkeys-boil.md
rename-flags-to-flagship.md
rename-browser-run.md
c3-frameworks-update-12714.md
dependabot-update-13557.md
native-dev-registry-proxy.md
nasty-years-taste.md
r2-bucket-list-no-config.md
fix-ipv6-localhost-spin.md
local-explorer-ui-fix-occured-typo.md
Checks Performed
|
Various fixes mostly around using
exportsinstead ofSELF.each fixture has its own commit
with a bonus semi-related docs PR
A picture of a cute animal (not mandatory, but encouraged)