Skip to content

Revert "Replace HTTP dev-registry proxy with native workerd debug port RPC"#13563

Closed
penalosa wants to merge 1 commit intomainfrom
revert-12600-penalosa/native-registry
Closed

Revert "Replace HTTP dev-registry proxy with native workerd debug port RPC"#13563
penalosa wants to merge 1 commit intomainfrom
revert-12600-penalosa/native-registry

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Apr 16, 2026

Reverts #12600


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

⚠️ No Changeset found

Latest commit: 32398ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 16, 2026
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 16, 2026

The analysis confirms this is a perfectly clean revert — the post-revert state is byte-identical to the pre-#12600 state. No logical bugs, no stale references, no incomplete changes. The only potential item is the missing changeset, but the changeset bot already flagged this and it's standard for revert PRs to use the no-changeset-required label.

LGTM

github run

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 4 potential issues.

View 6 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/miniflare/src/http/fetch.ts
Comment thread packages/miniflare/src/index.ts
Comment thread packages/miniflare/src/shared/dev-registry.worker.ts
Comment thread packages/miniflare/src/workers/assets/rpc-proxy.worker.ts
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13563

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13563

miniflare

npm i https://pkg.pr.new/miniflare@13563

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13563

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13563

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13563

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13563

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13563

wrangler

npm i https://pkg.pr.new/wrangler@13563

commit: 32398ec

@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Apr 16, 2026
@penalosa penalosa closed this Apr 16, 2026
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants