Skip to content

Simplify /cdn-cgi/ handling#13634

Open
jamesopstad wants to merge 3 commits intomainfrom
revert-12855-james/vite-explorer
Open

Simplify /cdn-cgi/ handling#13634
jamesopstad wants to merge 3 commits intomainfrom
revert-12855-james/vite-explorer

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad commented Apr 22, 2026

This reverts #12855 and adds a test to ensure that the Local Explorer UI is served. It turns out that the changes in that PR were unnecessary (I'm not sure if that was true at the time or if something has changed since).

The only /cdn-cgi/ routes we need to add special handling for are /cdn-cgi/handler/* so that trigger handlers invoke the User Worker.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

🦋 Changeset detected

Latest commit: b1882ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13634

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13634

miniflare

npm i https://pkg.pr.new/miniflare@13634

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13634

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13634

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13634

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13634

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13634

wrangler

npm i https://pkg.pr.new/wrangler@13634

commit: b1882ba

@jamesopstad jamesopstad force-pushed the revert-12855-james/vite-explorer branch from eeca145 to b1882ba Compare April 22, 2026 08:57
@jamesopstad jamesopstad marked this pull request as ready for review April 22, 2026 09:42
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team April 22, 2026 09:43
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/vite-plugin-cloudflare/playground/bindings/tests/worker.spec.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/playground/bindings/src/index.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/index.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/plugins/cdn-cgi.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/plugins/trigger-handlers.ts: [@cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants