[wrangler] Fix remote bindings hanging on shutdown

[apeacock1991]

Fixes #11254

startDev() registers dev hotkeys before authenticating the user. During interactive dev sessions, the auth callback re-registers hotkeys, which updates the local unregisterHotKeys variable to a new cleanup function. However, the unregisterHotKeys value returned to callers was captured as a direct reference to the initial registration, so it would call the stale cleanup function instead of the current one.

This PR fixes the bug by returning a wrapper function () => unregisterHotKeys?.() instead of the variable directly. The wrapper evaluates unregisterHotKeys at call time, ensuring it always invokes the latest cleanup function even after re-registration.

A unit test is added to verify that unregisterHotKeys() correctly calls the latest cleanup after auth triggers a re-registration.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: it's a bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 5fdb554

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

✅ All changesets look good

[ask-bonk]

I've now reviewed the entire PR. Let me analyze the changes:

The fix (start-dev.ts:208): Changes unregisterHotKeys to () => unregisterHotKeys?.() — this is correct. The unregisterHotKeys variable is reassigned at line 51 inside the authHook, so the old direct reference in the return value would become stale. The wrapper closure correctly captures the variable by reference, evaluating it at call time.

The test (start-dev.test.ts): The test correctly:

• Uses expect from test context (line 49)
• Mocks DevEnv, registerDevHotKeys, isInteractive, and requireAuth
• Exercises the auth re-registration path by extracting the auth hook from config.set call args and invoking it
• Asserts that result.unregisterHotKeys() calls the second cleanup function, not the first

The changeset: Correctly scoped to wrangler as a patch.

The code change is a one-line, well-targeted fix for a real closure capture bug. The test adequately covers the scenario. The changeset is appropriate.

LGTM

github run

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13887

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13887

miniflare

npm i https://pkg.pr.new/miniflare@13887

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13887

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13887

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13887

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13887

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13887

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13887

wrangler

npm i https://pkg.pr.new/wrangler@13887

commit: 5fdb554

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[dario-piotrowicz]

Looks good to me! (I feel that this bug as actually caused by me! 😅) Thanks @apeacock1991 😄

Could you maybe just expand on the changeset if possible? 🙏

[workers-devprod]

Codeowners reviews satisfied