allow specifying only "index" without extension or nothing at all to launch "wrangler dev"#196
Merged
threepointone merged 5 commits intomainfrom Jan 14, 2022
Merged
allow specifying only "index" without extension or nothing at all to launch "wrangler dev"#196threepointone merged 5 commits intomainfrom
threepointone merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: fc2ad31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jan 6, 2022
JacobMGEvans
reviewed
Jan 6, 2022
Contributor
JacobMGEvans
left a comment
There was a problem hiding this comment.
Looks good to me, looking forward to the bonus wrangler dev using default entrypoint
threepointone
requested changes
Jan 7, 2022
Contributor
threepointone
left a comment
There was a problem hiding this comment.
- Could you add a changeset please? Run
npx changesetin the root of the project, and add the title of this PR as a patch towrangler. - Could you also add this logic to
wrangler publish? Here - https://github.com/cloudflare/wrangler2/blob/19d3833433be55ede84740b0f99a951c608e0a23/packages/wrangler/src/publish.ts#L128
Merged
threepointone
added a commit
that referenced
this pull request
Jan 18, 2022
We introduced some bugs in recent PRs: - In #196, we broke being able to pass an entrypoint directly to the cli. In this PR, I just reverted that fix. I'll reopen #78 and we'll tackle it again later. (cc @jgentes) - In #215, we broke being able to publish a script by just passing `--latest` or `--compatibility-data` in the cli. This PR fixes that by reading the correct argument when choosing whether to publish. - In #247, we broke how we made requests by passing headers to requests. This PR reverts the changes made in `cfetch/internal.ts`. (cc @petebacondarwin) - In #244, we broke `dev` and it would immediately crash. This PR fixes the reference in `dev.tsx` that was breaking. (cc @petebacondarwin)
threepointone
added a commit
that referenced
this pull request
Jan 18, 2022
We introduced some bugs in recent PRs: - In #196, we broke being able to pass an entrypoint directly to the cli. In this PR, I just reverted that fix. I'll reopen #78 and we'll tackle it again later. (cc @jgentes) - In #215, we broke being able to publish a script by just passing `--latest` or `--compatibility-data` in the cli. This PR fixes that by reading the correct argument when choosing whether to publish. - In #247, we broke how we made requests by passing headers to requests. This PR reverts the changes made in `cfetch/internal.ts`. (cc @petebacondarwin) - In #244, we broke `dev` and it would immediately crash. This PR fixes the reference in `dev.tsx` that was breaking. (cc @petebacondarwin)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using
wrangler dev ./indexI getThis is caused due to the
entryvalue being verbatim what was used as a command line argument, ie../index, whereas theentryPointvalue inresult.metafile.outputshas the extension added to the file, ie./index.js.I'm going to submit a PR that uses what esBuild recognizes as the input value in
result.metafile.inputsinstead of theentryvalue: