Refactor proxy code to pass strict-null checks#248
Refactor proxy code to pass strict-null checks#248petebacondarwin merged 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 15d7a40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
I prefer inlined abstractions to prevent jumping around to understand the code, but ok.
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
Please add a changeset!
Yeah, I know what you mean. There is also the converse problem where the inlined function is so big that it is difficult to understand the calling code: i.e. it is difficult to see and understand the calling code in one go, since the rest of the code is off the screen. In this case, it felt that the benefits to the calling code outweighed the cost of not having the function inline. ( |
petebacondarwin
force-pushed
the
strict-null-checks-proxy
branch
from
7522fe3 to
ce2bd41
Compare
petebacondarwin
force-pushed
the
strict-null-checks-proxy
branch
from
ce2bd41 to
15d7a40
Compare
3 participants
No description provided.