Refactor index.tsx (and config.ts) to pass strict-null checks#249
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Jan 20, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: d218f2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
This is looking good, dropped a couple of notes. If you could bring back the snip comments I'd be happy to approve and land this and work on it further. thank you!
petebacondarwin
force-pushed
the
strict-null-checks-index
branch
2 times, most recently
from
07f95fd to
e4855b8
Compare
petebacondarwin
force-pushed
the
strict-null-checks-index
branch
from
e4855b8 to
6512193
Compare
petebacondarwin
force-pushed
the
strict-null-checks-index
branch
from
6512193 to
e277a4b
Compare
threepointone
approved these changes
Jan 19, 2022
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
approving with one last note. thanks!
petebacondarwin
force-pushed
the
strict-null-checks-index
branch
from
e277a4b to
3a58042
Compare
This actually slightly changes the processing of the environment configuration. Previously there were corner cases where the configuration might just crash. These are now handled more cleanly with more appropriate warnings. The yargs commands have been refactored slightly to be more consistent. Now each command that can be either in local or remote mode is structured the same way. The `config` is extracted from the args, then there is an `if-then-else` statement that handles the local and remote cases. This ensures that the `account_id` has the correct typings in remote mode as needed.
petebacondarwin
force-pushed
the
strict-null-checks-index
branch
from
3a58042 to
d218f2e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually slightly changes the processing of the environment configuration.
Previously there were corner cases where the configuration might just crash.
These are now handled more cleanly with more appropriate warnings.
The yargs commands have been refactored slightly to be more consistent.
Now each command that can be either in local or remote mode is structured the same way.
The
configis extracted from the args, then there is anif-then-elsestatement that handles the local and remote cases.This ensures that the
account_idhas the correct typings in remote mode as needed.