Refactor inspector code to pass strict-null checks#250
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Jan 18, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 124ee86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
requested changes
Jan 17, 2022
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
Please remove the useMemo usage.
petebacondarwin
force-pushed
the
strict-null-checks-inspector
branch
from
3e8456c to
8a8f3f9
Compare
threepointone
approved these changes
Jan 17, 2022
petebacondarwin
force-pushed
the
strict-null-checks-inspector
branch
from
8a8f3f9 to
124ee86
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some simple strict-null fixes but also a refactor to use react memo hooks in inspector code.
Previously the proxy server and websocket server were created in ref hooks.
But this prevented TypeScript from understanding that they were always defined when needed.
By using memo hooks we get this typing for free; and also can lean on react to handle recreating them as needed.