fix: skip unwanted files and directories when publishing site assets #280
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Jan 24, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 92d7f70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
keep-well-known
branch
from
2526ef4 to
c16222f
Compare
threepointone
approved these changes
Jan 24, 2022
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
I checked the last commit and it looked good to me.
petebacondarwin
force-pushed
the
keep-well-known
branch
from
c16222f to
a19ba3d
Compare
In keeping with Wrangler 1, we now skip node_modules and hidden files and directories. An exception is made for `.well-known`. See https://datatracker.ietf.org/doc/html/rfc8615. The tests also prove that the asset uploader will walk directories in general.
petebacondarwin
force-pushed
the
keep-well-known
branch
from
a19ba3d to
92d7f70
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sits on top of #277.
In keeping with Wrangler 1, we now skip node_modules and hidden files and directories.
An exception is made for
.well-known. See https://datatracker.ietf.org/doc/html/rfc8615.The tests also prove that the asset uploader will walk directories in general.