Make sure that the correct entrypoint file path is applied when bundling Pages applications

[dario-piotrowicz]

Fixes #4652

[changeset-bot]

🦋 Changeset detected

Latest commit: 96634f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7493808436/npm-package-wrangler-4676

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7493808436/npm-package-wrangler-4676

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7493808436/npm-package-wrangler-4676 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7493808436/npm-package-miniflare-4676

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7493808436/npm-package-cloudflare-pages-shared-4676

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7493808436/npm-package-create-cloudflare-4676 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.22.4 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231218.1
workerd	1.20231218.0	1.20231218.0
workerd --version	1.20231218.0	2023-12-18

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df71f26) 75.60% compared to head (96634f3) 75.71%.
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4676      +/-   ##
==========================================
+ Coverage   75.60%   75.71%   +0.11%     
==========================================
  Files         243      243              
  Lines       13096    13210     +114     
  Branches     3376     3393      +17     
==========================================
+ Hits         9901    10002     +101     
- Misses       3195     3208      +13     

Files	Coverage Δ
packages/wrangler/src/pages/dev.ts	16.43% <ø> (ø)

... and 62 files with indirect coverage changes

[petebacondarwin]

I think that entry.file should already be resolved by the time we hit this code.
In most cases it is. From looking up the call stack I think the problem is in packages/wrangler/src/pages/dev.ts: if the working directory is not defined then the script-path (aka singleWorkerScriptPath) is used without resolving it correctly.

[dario-piotrowicz]

Thanks a bunch @petebacondarwin 🙂

I've applied the change in the packages/wrangler/src/pages/dev.ts hopefully that's what you had in mind please let me know how that looks 🙂

[petebacondarwin]

I tested this locally by checking out the PR and running the following in the pages-dev-proxy-with-script fixture:

pnpm wrangler pages dev --proxy=9999 --script-path=custom/script/path/index.js

This fails with an error without the fix and works after the fix.