fix: remove confusing --local messaging from wrangler pages dev#4687
fix: remove confusing --local messaging from wrangler pages dev#4687
--local messaging from wrangler pages dev#4687Conversation
🦋 Changeset detectedLatest commit: b82875d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7389823023/npm-package-wrangler-4687Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-wrangler-4687 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-miniflare-4687npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-cloudflare-pages-shared-4687npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7389823023/npm-package-create-cloudflare-4687 --no-auto-updateNote that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4687 +/- ##
==========================================
+ Coverage 75.58% 75.61% +0.02%
==========================================
Files 243 243
Lines 13084 13084
Branches 3368 3368
==========================================
+ Hits 9890 9893 +3
+ Misses 3194 3191 -3
|
24c41df to
b82875d
Compare
--local messaging from wrangler pages dev--local messaging from wrangler pages dev
|
Already discussed in person, but flagging here for posterity: The warning now doesn't appear if you don't set The warning ALSO doesn't appear if you DO set |
Fixes #4210.
What this PR solves / how to test:
Running
wrangler pages devwould previously log a warning saying--local is no longer requiredeven though--localwas never set. This change removes this warning. To test this, runwrangler pages devand make sure--local is no longer requireddoesn't appear.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.