bump C3's create-next-app to 15.0.3 by dario-piotrowicz · Pull Request #7241 · cloudflare/workers-sdk

dario-piotrowicz · 2024-11-12T17:19:36Z

This PR is for updating C3 to create a Next.js 15 app in non-experimental mode

However (see comments below) the bump of create-next-app for non-experimental mode currently applies to both the non-experimental and experimental Next.js templates, forcing us to either make sure that both templates can work with Next.js 15 or that we find a way to have each use a different version of create-next-app

Tests
- TODO (before merge)
- Tests included (the quarantined e2e Next.js test has been updated)
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: I think that the Next.js (non-experimental) e2e test isn't run because it is quarantined
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: it's just a version bump

github-actions · 2024-11-12T17:24:08Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-wrangler-7241

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7241/npm-package-wrangler-7241

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-wrangler-7241 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-create-cloudflare-7241 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-kv-asset-handler-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-miniflare-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-pages-shared-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-vitest-pool-workers-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-workers-editor-shared-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-workers-shared-7241

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12282270102/npm-package-cloudflare-workflows-shared-7241

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.95.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241205.0
`workerd`	1.20241205.0	1.20241205.0
`workerd --version`	1.20241205.0	2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

changeset-bot · 2024-12-08T12:52:08Z

🦋 Changeset detected

Latest commit: 8dfcae6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dario-piotrowicz · 2024-12-08T20:38:53Z

Note

This PR updates the non-experimental Next.js C3 template, so I think that the C3 E2E Tests (experimental) checks (which are failing because of Next.js) can safely be ignored (I can deal with them in a followup PR if that's ok?)

andyjessop

Looks great, thanks @dario-piotrowicz

petebacondarwin

so I think that the C3 E2E Tests (experimental) checks (which are failing because of Next.js) can safely be ignored

I don't think it is fair to break the experimental Next.js support by bumping the Next.js dependency.
If we can't separate them to use different versions of Next.js then I think we need to ensure they are both fixed together.

dario-piotrowicz · 2024-12-09T11:52:02Z

so I think that the C3 E2E Tests (experimental) checks (which are failing because of Next.js) can safely be ignored

I don't think it is fair to break the experimental Next.js support by bumping the Next.js dependency. If we can't separate them to use different versions of Next.js then I think we need to ensure they are both fixed together.

ah yeah for sure! I was under the assumption that the experimental e2e was failing either way I didn't realize the bump was breaking it (but it clearly runs without the bump: example run)

it's quite unfortunate that the create-next-app bump effects both templates 😕 😓

petebacondarwin · 2024-12-09T11:54:34Z

I think @vicb was working up updating opennextjs?

dario-piotrowicz · 2024-12-09T11:57:54Z

I'm looking at the code and I don't think there's a clean way to use different versions of create-next-app 😓

We could have a new package.json just for the experimental templates... that feels like the cleanest solution, but also very much overkill for just Next.js 😓

Alternatively we could have some very hacky if statement that overrides the create-next-app version for the experimental Next.js template...

Or yeah just wait for our opennext adapter to support Next 15 😓

vicb · 2024-12-10T22:45:52Z

Haven't looked at the details but the experimental branch should have an open next config file and a different wrangler.toml.
Should they be updated as part of the PR?

Also loading instrumentation will fall on 15.0.3 if not patched.

ah yeah of course, good callout 😓👍

dario-piotrowicz · 2024-12-11T10:13:12Z

@petebacondarwin what do you think of this temporary workaround for the experimental template issue?

d2bd8b1

vicb · 2024-12-11T10:17:00Z

Another option would be to allow frameworkCli to specify the version (i.e. create-next-app@14.2.5)

I think this approach is fine. You could even change it to something to make it clear this is exceptional:

Suggested change

frameworkCliVersion?: string;

pinFrameworkCliVersion?: string;

We use dependabot to keep the CLI versions up to date, which is why they are stored in a package.json. Moving the versions here would mess that up. But in this case we don't want dependabot to do anything with this version since we are explictly pinning it.

My proposal is to use either cli to use the version from the package.json or cli@version to pin the version as an alternative to using the pinFrameworkCliVersion property

Yes I understand. But in doing that it is not clear that this is not the intended normal way to specify the version in cases where we do not need to pin the version.

@petebacondarwin I've renamed the field as you suggested 🙂

I've also updated the comment to make the thing a bit clearer

c36670d

petebacondarwin · 2024-12-11T11:54:49Z

I think this approach is fine. You could even change it to something to make it clear this is exceptional:

Suggested change

frameworkCliVersion?: string;

pinFrameworkCliVersion?: string;

We use dependabot to keep the CLI versions up to date, which is why they are stored in a package.json. Moving the versions here would mess that up. But in this case we don't want dependabot to do anything with this version since we are explictly pinning it.

…app v.15)

This reverts commit d0b9ceec5c5f06188906fa165529df6fda09250b.

…create-next-app cli

dario-piotrowicz force-pushed the dario/c3-next-15 branch from 75aa685 to 341684a Compare December 8, 2024 12:49

dario-piotrowicz marked this pull request as ready for review December 8, 2024 20:55

dario-piotrowicz requested a review from a team as a code owner December 8, 2024 20:55

dario-piotrowicz requested a review from a team December 8, 2024 20:55

dario-piotrowicz mentioned this pull request Dec 8, 2024

[C3] Bump create-next-app from 14.2.5 to 15.0.3 in /packages/create-cloudflare/src/frameworks #7202

Closed

andyjessop approved these changes Dec 9, 2024

View reviewed changes

petebacondarwin requested changes Dec 9, 2024

View reviewed changes

vicb reviewed Dec 10, 2024

View reviewed changes

vicb reviewed Dec 11, 2024

View reviewed changes

petebacondarwin approved these changes Dec 11, 2024

View reviewed changes

dario-piotrowicz added 7 commits December 11, 2024 17:25

bump C3's create-next-app to 15.0.3

be8ce3d

update next.js template and tests (so that it works with create-next-…

ba8b9ab

…app v.15)

add changeset

fd26250

use experimental realase of @opennextjs/cloudflare

40a4e3e

Revert "use experimental realase of @opennextjs/cloudflare"

074f2a0

This reverts commit d0b9ceec5c5f06188906fa165529df6fda09250b.

make the Next.js experimental template use a specific version of the …

0fbfbda

…create-next-app cli

rename frameworkCliVersion to pinFrameworkCli

3eaa022

dario-piotrowicz force-pushed the dario/c3-next-15 branch from c36670d to 3eaa022 Compare December 11, 2024 17:25

vicb reviewed Dec 11, 2024

View reviewed changes

Comment thread packages/create-cloudflare/src/templates.ts Outdated

rename pinFrameworkCli to frameworkCliPinnedVersion

8dfcae6

dario-piotrowicz requested a review from vicb December 11, 2024 18:06

dario-piotrowicz merged commit d8e96b2 into main Dec 12, 2024

dario-piotrowicz deleted the dario/c3-next-15 branch December 12, 2024 12:33

workers-devprod mentioned this pull request Dec 12, 2024

Version Packages #7514

Merged

	frameworkCliVersion?: string;
	pinFrameworkCliVersion?: string;

Conversation

dario-piotrowicz commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dario-piotrowicz commented Dec 8, 2024

Uh oh!

andyjessop left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Dec 9, 2024

Uh oh!

petebacondarwin commented Dec 9, 2024

Uh oh!

dario-piotrowicz commented Dec 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dario-piotrowicz commented Nov 12, 2024 •

edited

Loading

github-actions Bot commented Nov 12, 2024 •

edited

Loading

changeset-bot Bot commented Dec 8, 2024 •

edited

Loading

dario-piotrowicz commented Dec 11, 2024 •

edited

Loading