Conversation
🦋 Changeset detectedLatest commit: 49df280 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamesopstad
force-pushed
the
james/export-config-types
branch
from
2b60169 to
fa4cd2b
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-wrangler-7256You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7256/npm-package-wrangler-7256Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-wrangler-7256 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-create-cloudflare-7256 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-kv-asset-handler-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-miniflare-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-pages-shared-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-vitest-pool-workers-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-workers-editor-shared-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-workers-shared-7256npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12158931737/npm-package-cloudflare-workflows-shared-7256Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
jamesopstad
changed the title
| configPath: string, | ||
| env?: string | ||
| ): { | ||
| interface MiniflareWorkerOptions { |
There was a problem hiding this comment.
We should export this interface too.
|
Can we export these with an experimental/unstable name (or at least a comment to that effect)? We're about to work on a first-class API for doing this (DEVX-1423 & DEVX-1424) which is probably what we'd want frameworks to be using longer term |
jamesopstad
force-pushed
the
james/export-config-types
branch
from
e4f872e to
145d6c0
Compare
jamesopstad
force-pushed
the
james/export-config-types
branch
from
145d6c0 to
49df280
Compare
|
|
||
| export { readConfig as unstable_readConfig }; | ||
| export type { | ||
| Config as UnstableConfig, |
There was a problem hiding this comment.
Quick question, should we use Unstable_Config, etc. similar to unstable_readConfig?
There was a problem hiding this comment.
In the future there might actually be a type that starts with Unstable...
There was a problem hiding this comment.
I was going to do that but noticed there are already some types named like this without the underscore e.g. UnstableDevOptions, UnstableDevWorker. Thought it was better to keep it consistent.
There was a problem hiding this comment.
Oh... 😢
I think that was probably a bad idea. But I guess it's best to stick with the convention.
There was a problem hiding this comment.
You can change them all if you like (they're called unstable so people can't exactly say they haven't been warned). That should probably be in a separate PR though.
|
We're going to land this and then follow up today with a PR to rename all unstable types to be prefixed with |
4 participants
In the Vite plugin we are looking at generating
wrangler.jsonfiles as part of the build process. Exporting these utils and types enables us to do this.