Skip to content

chore: bump vitest in templates#7384

Merged
penalosa merged 5 commits intocloudflare:mainfrom
Cherry:chore/bump-vitest-init
Dec 5, 2024
Merged

chore: bump vitest in templates#7384
penalosa merged 5 commits intocloudflare:mainfrom
Cherry:chore/bump-vitest-init

Conversation

@Cherry
Copy link
Copy Markdown
Contributor

@Cherry Cherry commented Nov 28, 2024

Fixes N/A

This PR simply bumps vitest in the C3 templates to the latest version currently supported, 2.1.6.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no functional changes - dependency bump
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no functional changes - dependency bump
  • Public documentation

@Cherry Cherry requested a review from a team as a code owner November 28, 2024 17:18
@Cherry Cherry requested a review from a team November 28, 2024 17:18
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 7a54250

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 28, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-wrangler-7384

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7384/npm-package-wrangler-7384

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-wrangler-7384 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-create-cloudflare-7384 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-kv-asset-handler-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-miniflare-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-pages-shared-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-vitest-pool-workers-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-workers-editor-shared-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-workers-shared-7384
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12182927571/npm-package-cloudflare-workflows-shared-7384

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@kobuomhoat
Copy link
Copy Markdown

Hdb

@penalosa penalosa force-pushed the chore/bump-vitest-init branch from 6de713a to b7f8dec Compare December 2, 2024 14:55
@Skye-31
Copy link
Copy Markdown
Contributor

Skye-31 commented Dec 2, 2024

Should this be 2.1.8 now? I understand that the issues in 2.1.6 were fixed in 2.1.7, so they should be safe

@Cherry
Copy link
Copy Markdown
Contributor Author

Cherry commented Dec 2, 2024

2.1.8 should be fine now if we want to bump it again. It's functionally equivalent to 2.1.5 except also allowing Node 21 in its engines.

@penalosa penalosa force-pushed the chore/bump-vitest-init branch from 7a54250 to 44c41fd Compare December 5, 2024 15:30
@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Dec 5, 2024

@Cherry I've also bumped the pnpm workspace version to 2.1.8, just to make sure we're running tests on the right version, but this should go out in today's release. Thanks for the PR!

@penalosa penalosa merged commit 55ec38a into cloudflare:main Dec 5, 2024
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2024
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Dec 5, 2024
@holopin-bot
Copy link
Copy Markdown

holopin-bot Bot commented Dec 5, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4blvoh508000cmkgk89vwax

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants