Skip to content

Add support for Images binding#7424

Merged
andyjessop merged 11 commits intocloudflare:mainfrom
ns476:images-binding
Jan 23, 2025
Merged

Add support for Images binding#7424
andyjessop merged 11 commits intocloudflare:mainfrom
ns476:images-binding

Conversation

@ns476
Copy link
Copy Markdown
Contributor

@ns476 ns476 commented Dec 3, 2024

Fixes IMAGES-1400, IMAGES-1401, IMAGES-1402

Adds support for the Images binding, with two kinds of preview:

  • Remote: hits a remote endpoint that exposes the same HTTP interface used in production
  • Local: uses a local fake that only supports rotating, resizing and transcoding, intended mainly for use in tests.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: For the time being this is in private beta - docs are being worked on separately.

@ns476 ns476 requested review from a team as code owners December 3, 2024 15:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 55fa3b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-wrangler-7424

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7424/npm-package-wrangler-7424

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-wrangler-7424 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-workers-bindings-extension-7424 -O ./cloudflare-workers-bindings-extension.0.0.0-vb2cef86fa.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb2cef86fa.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-create-cloudflare-7424 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-kv-asset-handler-7424

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-miniflare-7424

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-pages-shared-7424

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-unenv-preset-7424

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-vite-plugin-7424

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-vitest-pool-workers-7424

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-workers-editor-shared-7424

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-workers-shared-7424

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12918391979/npm-package-cloudflare-workflows-shared-7424

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.105.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the blocked Blocked on other work label Dec 5, 2024
@penalosa penalosa marked this pull request as draft December 9, 2024 10:18
@penalosa
Copy link
Copy Markdown
Contributor

penalosa commented Dec 9, 2024

@ns476 It doesn't look like this is ready for review yet, so I've converted this to draft for now

@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 14, 2025
@ns476 ns476 force-pushed the images-binding branch 5 times, most recently from 7bf3bec to 61b1c52 Compare January 14, 2025 15:27
@penalosa penalosa marked this pull request as ready for review January 15, 2025 13:34
@ns476 ns476 force-pushed the images-binding branch 5 times, most recently from 6ff5c84 to cd32d24 Compare January 17, 2025 11:06
Comment thread packages/wrangler/src/config/environment.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread .npmrc Outdated
Comment thread packages/wrangler/e2e/dev-with-resources.test.ts Outdated
Comment thread packages/wrangler/src/dev.ts Outdated
Comment thread packages/wrangler/src/dev/miniflare.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/images/local.ts Outdated
Comment thread packages/wrangler/src/pages/dev.ts Outdated
Comment thread packages/wrangler/src/utils/print-bindings.ts Outdated
@CarmenPopoviciu CarmenPopoviciu removed the blocked Blocked on other work label Jan 21, 2025
Comment thread packages/wrangler/src/__tests__/config/configuration.test.ts Outdated
Copy link
Copy Markdown
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving here to unblock for merge, as all the conversations have been resolved.

@andyjessop andyjessop merged commit a7163b3 into cloudflare:main Jan 23, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jan 23, 2025
@holopin-bot
Copy link
Copy Markdown

holopin-bot Bot commented Jan 23, 2025

Congratulations @ns476, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm6930b2a98230cjx36e1h0a8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

andyjessop added a commit that referenced this pull request Jan 23, 2025
emily-shen pushed a commit that referenced this pull request Jan 23, 2025
@edmundhung edmundhung mentioned this pull request Jan 29, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants