Skip to content

Fix Pages tmp dir location#7441

Closed
penalosa wants to merge 5 commits intomainfrom
penalosa/fix-pages-tmp-dir
Closed

Fix Pages tmp dir location#7441
penalosa wants to merge 5 commits intomainfrom
penalosa/fix-pages-tmp-dir

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Dec 4, 2024

Fixes #7440

Fix a regression introduced in #7415 with the tmp dir location for Pages projects


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa added the e2e Run wrangler + vite-plugin e2e tests on a PR label Dec 4, 2024
@penalosa penalosa requested review from a team as code owners December 4, 2024 15:50
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 227a43c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/wrangler/e2e/pages-dev.test.ts Outdated
@GregBrimble
Copy link
Copy Markdown
Contributor

Changeset?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-wrangler-7441

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7441/npm-package-wrangler-7441

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-wrangler-7441 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-create-cloudflare-7441 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-kv-asset-handler-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-miniflare-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-pages-shared-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-vitest-pool-workers-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-workers-editor-shared-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-workers-shared-7441
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169341790/npm-package-cloudflare-workflows-shared-7441

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

penalosa and others added 3 commits December 4, 2024 15:57
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
@petebacondarwin petebacondarwin marked this pull request as draft December 4, 2024 22:51
@petebacondarwin
Copy link
Copy Markdown
Contributor

Let's just revert for now... #7446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: Latest wrangler causing a ton of hot reloads because it's putting the .wrangler/tmp directory inside /functions

3 participants