Skip to content

refactor: Ensure that unstable type exports are all prefixed with Unstable_ rather than just Unstable#7454

Merged
penalosa merged 1 commit intomainfrom
pbd/update-unstable-type-exports-prefix
Dec 5, 2024
Merged

refactor: Ensure that unstable type exports are all prefixed with Unstable_ rather than just Unstable#7454
penalosa merged 1 commit intomainfrom
pbd/update-unstable-type-exports-prefix

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

Fixes #0000

We use unstable_ as a prefix for experimental/unstable functions, but we were using just Unstable without the underscore as a prefix for types.

This change ensures that all unstable type exports are prefixed with Unstable_ rather than just Unstable.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactor

@petebacondarwin petebacondarwin requested a review from a team as a code owner December 5, 2024 14:30
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 5771e27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Dec 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-wrangler-7454

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7454/npm-package-wrangler-7454

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-wrangler-7454 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-create-cloudflare-7454 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-kv-asset-handler-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-miniflare-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-pages-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-vitest-pool-workers-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workers-editor-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workers-shared-7454
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12181816570/npm-package-cloudflare-workflows-shared-7454

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit f2045be into main Dec 5, 2024
@penalosa penalosa deleted the pbd/update-unstable-type-exports-prefix branch December 5, 2024 17:06
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants